chore: upgrade to vue 2.6 #1370
Conversation
|
i will have a look about changes but it looks really great. I will resolve conflicts if you dont @shigma |
flozero
added
complexity: medium
| @@ -0,0 +1,13 @@ | |||
| <template> | |||
There was a problem hiding this comment.
What is this Layout2 component about?
There was a problem hiding this comment.
yeah it seem useless... i didnt pay attention on it
| @@ -33,6 +33,10 @@ | |||
| "vue-jest": "^4.0.0-beta.1", | |||
| "vue-template-compiler": "^2.5.16" | |||
| }, | |||
| "peerDependencies": { | |||
There was a problem hiding this comment.
Why now would we need these two dependencies as peerDependencies?
There was a problem hiding this comment.
in test utils we no mention of vuejs. It's just a protection to say i need at least vue 2x to work. It installing nothing
| @@ -20,7 +20,9 @@ const tocPlugin = require('markdown-it-table-of-contents') | |||
| const { | |||
| slugify: _slugify, | |||
| parseHeaders, | |||
| logger, chalk, normalizeConfig, | |||
There was a problem hiding this comment.
Could you revert the changes about formatted code?
There was a problem hiding this comment.
it is a format from the code it should happen i think
There was a problem hiding this comment.
I don't see any config for code format in the vuepress repos. In this case, I think we should not do changes about code formatting in PRs to avoid unnecessary changes.
There was a problem hiding this comment.
i will revert that change yeah
|
As you create a new one i close this one #1370 |
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: